Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sass importer can't be undefined (fix: #3390) #3395

Merged
merged 1 commit into from May 13, 2021

Conversation

axe-me
Copy link
Contributor

@axe-me axe-me commented May 13, 2021

Description

fix: #3390

Only add in the sass importer option when it's defined in the config.
Also checks if the importer config is an array or not;

In this PR, I update some TS types as well.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev
Copy link
Member

For reference, fixes a regression introduced by #3368 in v2.3.2

@patak-dev patak-dev requested review from antfu and underfin May 13, 2021 04:47
@antfu antfu merged commit 30ff5a2 into vitejs:main May 13, 2021
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 13, 2021
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@import of sass in 2.3.2 fails
4 participants