Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): strip utf-8 bom (#3162) #3171

Merged
merged 2 commits into from May 1, 2021
Merged

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Apr 27, 2021

Description

fix #3162
recommit this PR #814
vite build has no such problem, so only importAnalysis.ts needs to be modified.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 previously approved these changes Apr 27, 2021
@Shinigami92
Copy link
Member

Is it possible to add a test for this?

@Shinigami92 Shinigami92 added the p2-edge-case Bug, but has workaround or limited in scope (priority) label Apr 27, 2021
@ygj6
Copy link
Member Author

ygj6 commented Apr 29, 2021

Is it possible to add a test for this?

Hi, I've added a unit test. Please review it, Thx!

@underfin underfin merged commit 19a2869 into vitejs:main May 1, 2021
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
fi3ework pushed a commit to fi3ework/vite that referenced this pull request May 22, 2021
@sapphi-red sapphi-red mentioned this pull request Jun 16, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UTF-8 with BOM files cause vite to fail import rewrite
4 participants