Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow overwrite TerserOptions.safari10 from UserConfig #3113

Merged
merged 1 commit into from Apr 27, 2021
Merged

feat: Allow overwrite TerserOptions.safari10 from UserConfig #3113

merged 1 commit into from Apr 27, 2021

Conversation

cawa-93
Copy link
Contributor

@cawa-93 cawa-93 commented Apr 23, 2021

Description

A simple patch that allows you to overwrite TerserOptions.safari10 from UserConfig.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 23, 2021
@patak-dev patak-dev requested a review from antfu April 23, 2021 15:16
@antfu antfu merged commit 7cd8d78 into vitejs:main Apr 27, 2021
@cawa-93 cawa-93 deleted the terser-options-overwrite branch April 28, 2021 08:56
TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
@cawa-93 @TobiasMelen
feat: Allow overwrite TerserOptions.safari10 from UserConfig (vit…
e42455a 
…ejs#3113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cawa-93 @patak-dev @Shinigami92 @antfu