New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ora swallow rollup warning when building #268

Closed

csr632 opened this issue May 26, 2020 · 1 comment · Fixed by #269

Labels

Member

csr632 commented May 26, 2020 •

edited

Describe the bug

console.xxx should be used carefully when ora spinner is running: sindresorhus/ora#90

Currently, spinner is swallowing rollup warning when building.

Reproduction

https://github.com/csr632/test-vite/tree/reproduce-vite-268
Execute npm run build, rollup should warn about import { asd } from "asdasd"; can not be resolved. But currently you can't see any warning.

The text was updated successfully, but these errors were encountered:

csr632 added the pending triage label

csr632 added a commit to csr632/test-vite that referenced this issue


          reproduce vitejs/vite#268

8bf281c

csr632 mentioned this issue

fix: ora swallow rollup warning #269

Merged

Member Author

csr632 commented May 26, 2020

Fixed: #269

yyx990803 closed this as completed in #269

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.