Line limit from esbuild breaks vite production build

[Xerios]

Describe the bug

Cross-post from esbuild: evanw/esbuild#3735

---

Using low values for lineLimit such as 160 or 80 seems to break dynamic import from Vite as seen in my results below:

Line limit 160:

prop: ()=>Xn(()=>Promise.resolve().then(()=>BW), "\
__VITE_PRELOAD__"),

Line limit 500:

prop: ()=>Xn(()=>Promise.resolve().then(()=>BW), void 0)

the actual code itself is a function that imports a svelte file:

prop: () => import('./someSvelteFile.svelte'),

I don't fully understand the underlying but due to the "\ it seems like Vite no longer replaces __VITE_PRELOAD__

Reproduction

n/a

Steps to reproduce

Unfortunately I couldn't manage to properly reproduce this issue in a minimal example, but in our large code-base it definitely happens consistently

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (32) x64 13th Gen Intel(R) Core(TM) i9-13900K
    Memory: 14.89 GB / 31.76 GB
  Binaries:
    Node: 18.20.2 - C:\Program Files\nodejs\node.EXE  
    Yarn: 1.22.19 - C:\Program Files\nodejs\yarn.CMD  
    npm: 9.6.2 - C:\Program Files\nodejs\npm.CMD      
    pnpm: 9.0.6 - C:\Program Files\nodejs\pnpm.CMD    
  Browsers:
    Edge: Chromium (123.0.2420.97)
  npmPackages:
    vite: ^5.2.10 => 5.2.10

Used Package Manager

pnpm

Logs

n/a

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Didn't know that you can break strings this way. Seems like this should be fixable in Vite by relaxing this regex:

vite/packages/vite/src/node/plugins/importAnalysisBuild.ts

Line 40 in b7ddfae

const preloadMarkerWithQuote = new RegExp(`['"]${preloadMarker}['"]`, 'g')

Could also write a new unit test for this regex if anyone likes to fix this.