Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bundle/minimize code for Node.js consumption #14548

Open
7 tasks done
gajus opened this issue Oct 6, 2023 · 0 comments
Open
7 tasks done

Do not bundle/minimize code for Node.js consumption #14548

gajus opened this issue Oct 6, 2023 · 0 comments

Comments

@gajus
Copy link
Contributor

gajus commented Oct 6, 2023

This is describing the vite package itself.

Describe the bug

The problem is that because the code is bundled there is no way to patch an issue locally.

.
├── LICENSE.md
├── README.md
├── bin
│   ├── openChrome.applescript
│   └── vite.js
├── client.d.ts
├── dist
│   ├── client
│   │   ├── client.mjs
│   │   ├── client.mjs.map
│   │   ├── env.mjs
│   │   └── env.mjs.map
│   ├── node
│   │   ├── chunks
│   │   │   ├── dep-24337c19.js
│   │   │   ├── dep-2b82a1ce.js
│   │   │   ├── dep-4950a6a7.js
│   │   │   ├── dep-c423598f.js
│   │   │   └── dep-f0c7dae0.js
│   │   ├── cli.js
│   │   ├── constants.js
│   │   ├── index.d.ts
│   │   └── index.js
│   └── node-cjs
│       └── publicUtils.cjs
├── index.cjs
├── package.json
└── types
    ├── customEvent.d.ts
    ├── hmrPayload.d.ts
    ├── hot.d.ts
    ├── importGlob.d.ts
    ├── importMeta.d.ts
    ├── metadata.d.ts
    └── package.json

For instance, I would want to apply this fix locally using pnpm patch, but it is virtually not possible because the entire code is mangled.

I can still apply a patch for the current version, but because the bundle chunks are unstable, it will very likely break in the next version.

Reproduction

N/A

Steps to reproduce

No response

System Info

N/A

Used Package Manager

npm

Logs

No response

Validations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants