Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose loadEnv in public api #1300

Merged
merged 1 commit into from Jan 2, 2021
Merged

feat: expose loadEnv in public api #1300

merged 1 commit into from Jan 2, 2021

Conversation

cawa-93
Copy link
Contributor

@cawa-93 cawa-93 commented Jan 2, 2021

This function was in the public api, but now - no

@yyx990803
Copy link
Member

This was never meant to be public. What are you using it for?

@cawa-93
Copy link
Contributor Author

cawa-93 commented Jan 2, 2021 •
edited

I once submitted PR this (#1069)
In my project, I use this feature to automatically create env.d.ts files describing the types of import.meta.env for each MODE
https://github.com/cawa-93/vite-electron-builder/blob/main/bin/buildEnvTypes.js

@yyx990803 yyx990803 merged commit 9d0a8e7 into vitejs:main Jan 2, 2021
@cawa-93
Copy link
Contributor Author

cawa-93 commented Jan 2, 2021

@yyx990803 You're the best ❤️

@cawa-93 cawa-93 deleted the patch-1 branch January 2, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cawa-93 @yyx990803