Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vite 4 Regression] $ vite preview doesn't serve dist/about.html #11346

Closed
7 tasks done
brillout opened this issue Dec 12, 2022 · 3 comments
Closed
7 tasks done

[Vite 4 Regression] $ vite preview doesn't serve dist/about.html #11346

brillout opened this issue Dec 12, 2022 · 3 comments

Comments

@brillout
Copy link
Contributor

brillout commented Dec 12, 2022

Describe the bug

dist/index.html # Works and is served at '/'
dist/about.html # Doesn't work: '/about' returns a 404
dist/jobs/index.html # Works and is served at '/jobs'

(The reproduction isn't minimal but I believe it isn't required to be minimal to debug this. Let me know if you want a minimal reproduction.)

Reproduction

https://github.com/brillout/reprod-vite-preview-bug

Steps to reproduce

git clone git@github.com:brillout/reprod-vite-preview-bug
cd reprod-vite-preview-bug/
pnpm install
pnpm build
pnpm demo:preview

Same as single line (copy-paste me):

git clone git@github.com:brillout/reprod-vite-preview-bug && cd reprod-vite-preview-bug/ && pnpm install && pnpm run build && pnpm demo:preview

Go to localhost:3000/about and observe:

Actual behavior: 404.

Expected behavior: dist/client/about.html should be served.

System Info

System:
    OS: Linux 5.10 Debian GNU/Linux 10 (buster) 10 (buster)
    CPU: (2) x64 Intel(R) Celeron(R) N4020 CPU @ 1.10GHz
    Memory: 1.38 GB / 2.71 GB
    Container: Yes
    Shell: 5.0.3 - /bin/bash
  Binaries:
    Node: 18.0.0 - ~/.config/nvm/versions/node/v18.0.0/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.6.0 - ~/.config/nvm/versions/node/v18.0.0/bin/npm
  Browsers:
    Firefox: 97.0.1
  npmPackages:
    @vitejs/plugin-react-swc: ^3.0.0 => 3.0.0 
    vite: ^4.0.0 => 4.0.0

Used Package Manager

pnpm

Logs

No response

Validations

@patak-dev
Copy link
Member

@brillout did you check against main, we just merged #11312?
I'll do a patch release in a few hours

@brillout
Copy link
Contributor Author

I'll do a patch release in a few hours

👍 Will try again then and report back.

@brillout
Copy link
Contributor Author

Just tried against main and it works.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants