Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: derive useDefineForClassFields value from tsconfig.compilerOptions.target (fixes #10296) #11301

Merged
merged 3 commits into from Dec 11, 2022
Merged

fix: derive useDefineForClassFields value from tsconfig.compilerOptions.target (fixes #10296) #11301

merged 3 commits into from Dec 11, 2022

Conversation

sapphi-red
Copy link
Member

Description

The default value of useDefineForClassFields should be derived from compilerOptions.target instead of target.
See #10296 for more details.

fixes #10296

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Dec 10, 2022
patak-dev
patak-dev approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can merge after resolving the linting issues 👍🏼

@sapphi-red sapphi-red merged commit 42976d8 into vitejs:main Dec 11, 2022
@sapphi-red sapphi-red deleted the fix/use-define-for-class-fields branch December 11, 2022 07:33
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sapphi-red @futurGH
fix: derive useDefineForClassFields value from `tsconfig.compilerOp…
5dd0e08 
…tions.target` (fixes vitejs#10296) (vitejs#11301)
@sapphi-red sapphi-red mentioned this pull request Jun 15, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useDefineForClassFields value changed from 3.1 when it's derived from target
2 participants
@sapphi-red @patak-dev