Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links after moving Vite plugins out of core #11192

Closed
7 tasks done
Pezmc opened this issue Dec 5, 2022 · 3 comments
Closed
7 tasks done

Broken links after moving Vite plugins out of core #11192

Pezmc opened this issue Dec 5, 2022 · 3 comments

Comments

@Pezmc
Copy link

Pezmc commented Dec 5, 2022

Describe the bug

Several Vite ecosystem pages link to packages within the core repo pages directly e.g:

Pages include:

Since #11158 was merged these links now 404. It looks like the docs have been updated in GitHub but the website / npm have not been updated yet.

Currently after, hitting a 404, a user has to dig through Github issues to find the updated URL's since the packages are no longer linked from the readme.

Reproduction

https://vitejs.dev/plugins/

Steps to reproduce

The above pages link to the packages in core, which have now moved separate repos under https://github.com/vitejs/

e.g: https://github.com/vitejs/vite-plugin-vue/

Possible fix:

  • Temporarily add links to the other repos to vite core readme, to make it easier to self solve
  • Redeploy the Vite docs website
  • Long term, update npm.js and the docs to link to the other repos directly

System Info

n/a

Used Package Manager

npm

Logs

No response

Validations

@Pezmc Pezmc changed the title Broken links after moving plugin-vue out of core Broken links after moving Vite plugins out of core Dec 5, 2022
@ArnaudBarre
Copy link
Member

Vite docs are now up to date.

@patak-dev maybe we should keep two-lines Readme in core for a while to help people that are clicking on links from other sites/blogs?

@patak-dev
Copy link
Member

I thought about that, it is a pitty that GitHub doesn't give us a per-folder redirect to another repo. I think having the extra packages/... may also be confusing and we will end up with the same issue once we remove them. IMO the best is to try to get the main sites to change the links.

@bluwy
Copy link
Member

bluwy commented Dec 10, 2022

Closing as this is fixed now in the docs

@bluwy bluwy closed this as completed Dec 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants