Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(esbuild): handle inline sourcemap option #11120

Merged
merged 2 commits into from Nov 29, 2022
Merged

fix(esbuild): handle inline sourcemap option #11120

merged 2 commits into from Nov 29, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 29, 2022

Description

When passing sourcemap: 'inline' to transformWithEsbuild options, esbuild returns result.map = '' but we're trying to JSON.parse it which fails.

This PR skips JSON.parse for inline sourcemap

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 29, 2022
@patak-dev patak-dev merged commit 4c85c0a into main Nov 29, 2022
@patak-dev patak-dev deleted the esbuild-sourcemap-inline branch November 29, 2022 21:50
@bluwy bluwy mentioned this pull request Dec 1, 2022
Merged
bluwy added a commit that referenced this pull request Dec 5, 2022
@bluwy
fix(esbuild): handle inline sourcemap option (#11120)
754e43c
@bluwy bluwy mentioned this pull request Dec 5, 2022
Merged
patak-dev pushed a commit that referenced this pull request Dec 5, 2022
@bluwy @gtm-nayan
@julienv3 @sapphi-red
chore: cherry pick more v4 bug fixes to v3 (#11189)
eba9b42 
* fix: glob import parsing (#10949) (#11056)

closes #10949
closes #11051

* fix: import.meta.env and process.env undefined variable replacement (fix #8663) (#10958)

Co-authored-by: bluwy <bjornlu.dev@gmail.com>
fix #8663

* fix(esbuild): handle inline sourcemap option (#11120)

* fix(importGlob): preserve line count for sourcemap (#11122)

* fix: Dev SSR dep optimization + respect optimizeDeps.include (#11123)

* fix: reset global regex before match (#11132)

* chore: fix test

Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com>
Co-authored-by: julienv3 <julienv3@gmail.com>
Co-authored-by: 翠 / green <green@sapphi.red>
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@bluwy @futurGH
fix(esbuild): handle inline sourcemap option (vitejs#11120)
850b146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bluwy @sapphi-red @patak-dev