import.meta.glob breaks in Svelte template

[janosh]

Describe the bug

First reported in sveltejs/kit#7671.

According to @gtm-nayan

... this is a Vite bug because instead of transforming and replacing just the import.meta.glob('./*') part with an object, it's looking at the whole expression generated by Svelte to coerce the object to a string.

Reproduction

https://stackblitz.com/edit/vitejs-vite-hzfakv?file=package.json,src%2FApp.svelte

Steps to reproduce

No response

System Info

StackBlitz

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[Jevon617]

When using import.meta.glob("./*") in the Svelte template, it will be transformed to import. meta.glob("./*") + "", it is a BinaryExpression rather than a CallExpression, so the vite:import-glob plugin throws an error, should we support BinaryExpression for this situation?

[bluwy]

Yeah looks like we should support that. It can be fixed here to get the ast.left if it's a BinaryExpression.

vite/packages/vite/src/node/plugins/importMetaGlob.ts

Lines 157 to 165 in 7d24b5f

	if (ast.type === 'SequenceExpression')
	ast = ast.expressions[0] as CallExpression
	// immediate property access, call expression is nested
	// import.meta.glob(...)['prop']
	if (ast.type === 'MemberExpression') ast = ast.object as CallExpression
	if (ast.type !== 'CallExpression')
	throw err(`Expect CallExpression, got ${ast.type}`)

[github-actions]

Hello @janosh. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

[gtm-nayan]

There is another bug with parsing where an expression like import.meta.glob('./*.js')['./foo.js']() would fail because it looks at the whole string as a call expression and the second set of parens doesn't have a glob in it.

Would adding acorn-walk as a dep be acceptable? Then, it might be better to use findNodeAt as a more general solution instead of special-casing BinaryExpression.

[bluwy]

Would adding acorn-walk as a dep be acceptable? Then, it might be better to use findNodeAt as a more general solution instead of special-casing BinaryExpression.

Looks like it's only a small dependency. I'd be fine by that too 👍