Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent cache on optional package resolve (v3) (#10812) #10845

Merged
merged 1 commit into from Nov 9, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 9, 2022

cherry pick of #10812 for v3. looks like it isn't affecting heavily on ecosystem-ci

ref: withastro/astro#5145

@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Nov 9, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ✅ success
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member

@dominikg added support for testing the v3 branch on vite-ecosystem-ci. @bluwy I think you need to target v3 with this PR though 🤔. And then we can run ecosystem CI against it.

@bluwy bluwy changed the base branch from main to v3 November 9, 2022 09:29
@bluwy
Copy link
Member Author

bluwy commented Nov 9, 2022

Ughh I forgot to change that 😅

@patak-dev patak-dev merged commit 3ba45b9 into v3 Nov 9, 2022
@patak-dev patak-dev deleted the cherry-resolve-cache branch November 9, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants