refactor: change style.innerHTML to style.textContent #10801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
added
the
p2-nice-to-have
7 tasks
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
patak-dev
approved these changes
Nov 6, 2022
ghiscoding
added a commit
to ghiscoding/autocomplete
that referenced
this pull request
Nov 7, 2023
I think we should use `textContent` to reduce CSP (Content Security Policy) requirements. If we add CSP `require-trusted-types-for 'script'`, then it blocks `innerHTML` unless it's `TrustedHTML`, however in the case of this lib's usage, we can simply replace the `innerHTML` with `textContent` which has the exact same effect and is more CSP compliant For reference, you can see this [PR](vitejs/vite#10801) on the Vite project, they've done the exact same code change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems
innerHTMLandtextContentisn't different forstyletags. If there isn't any difference, I think we should use textContent to reduce CSP requirements.refs #10553
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).