clearScreen option can't be overwritten via plugin

[qodesmith]

Describe the bug

If I write a plugin that tries to set clearScreen: false in the config, it has no effect.

I know I can simply pass the option directly to defineConfig, but I'm reporting this because it's part of a plugin I'm writing that does other stuff but wants to ensure the screen is not cleared.

Reproduction

https://github.com/qodesmith/vite-keep-screen

Steps to reproduce

Neither keepScreen1 or keepScreen2 plugins will work. This is to showcase the 2 ways the documentation says you can update a config (via deep merge or directly editing the config object).

// vite.config.ts
import {defineConfig, PluginOption} from 'vite'
import react from '@vitejs/plugin-react'

// https://vitejs.dev/config/
export default defineConfig({
  plugins: [react(), keepScreen1()],
})

function keepScreen1(): PluginOption {
  return {
    name: 'vite-plugin-keep-screen1',
    config() {
      return {clearScreen: false}
    },
  }
}

function keepScreen2(): PluginOption {
  return {
    name: 'vite-plugin-keep-screen2',
    config(config) {
      config.clearScreen = false
    },
  }
}

System Info

System:
    OS: macOS 12.6
    CPU: (8) arm64 Apple M1 Pro
    Memory: 239.61 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.6.0 - ~/.nvm/versions/node/v18.6.0/bin/node
    npm: 8.13.2 - ~/.nvm/versions/node/v18.6.0/bin/npm
  Browsers:
    Brave Browser: 107.1.45.116
    Safari: 16.0
  npmPackages:
    @vitejs/plugin-react: ^2.2.0 => 2.2.0 
    vite: ^3.2.0 => 3.2.2

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bluwy]

Looks like we create the logger with the clearScreen option too early:

vite/packages/vite/src/node/config.ts

Lines 412 to 415 in 57916a4

	const logger = createLogger(config.logLevel, {
	allowClearScreen: config.clearScreen,
	customLogger: config.customLogger
	})

Feel free to send a PR to move this down!

[github-actions]

Hello @qodesmith. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

[qodesmith]

PR is up!