Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): url() with variable in sass/less (fixes #3644, #7651) #10741

Merged
merged 5 commits into from Nov 1, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 31, 2022

Description

fixes #3644
fixes #7651
superseds close #4269
superseds close #8765

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red changed the title \/variable in css url fix: variable in css url Oct 31, 2022
@sapphi-red sapphi-red changed the title fix: variable in css url fix(css): url() with variable in sass/less Oct 31, 2022
@sapphi-red sapphi-red changed the title fix(css): url() with variable in sass/less fix(css): url() with variable in sass/less (fixes #3644, #7651) Oct 31, 2022
@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Oct 31, 2022
@@ -14,7 +14,7 @@ module.exports = {
},
resolve: {
alias: {
'@': __dirname,
'=': __dirname,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced this to test less's variable. (less's variable starts with @)

related: https://github.com/vitejs/vite/pull/10741/files#diff-2cfbd4f4d8c32727cd8e1a561cffbde0b384a3ce0789340440e144f9d64c10f6R1608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
3 participants