chore: remove non used type definitions #10738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Oct 31, 2022
Comment on lines
-61
to
-77
| declare module '@rollup/plugin-dynamic-import-vars' { | ||
| import type { Plugin } from 'rollup' | ||
| import type { BaseNode } from 'estree' | ||
|
|
||
| interface Options { | ||
| include?: string | RegExp | (string | RegExp)[] | ||
| exclude?: string | RegExp | (string | RegExp)[] | ||
| warnOnError?: boolean | ||
| } | ||
|
|
||
| const p: (o?: Options) => Plugin | ||
| export default p | ||
| export function dynamicImportToGlob( | ||
| ast: BaseNode, | ||
| source: string | ||
| ): null | string | ||
| } |
There was a problem hiding this comment.
I'm not sure why this existed. But it seems this isn't necessary.
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
|
/ecosystem-ci run histoire |
patak-dev
approved these changes
Oct 31, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed non used type definitions from
shims.d.ts.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).