Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite 3.2.0 type definitions depend on picomatch #10656

Closed
7 tasks done
KamilaBorowska opened this issue Oct 27, 2022 · 1 comment · Fixed by #10678
Closed
7 tasks done

Vite 3.2.0 type definitions depend on picomatch #10656

KamilaBorowska opened this issue Oct 27, 2022 · 1 comment · Fixed by #10678
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release

Comments

@KamilaBorowska
Copy link

KamilaBorowska commented Oct 27, 2022

Describe the bug

Updating Vite to 3.2.0 causes TypeScript to complain about missing picomatch dependency, which is dev dependency of vite.

node_modules/vite/dist/node/index.d.ts(35,43): error TS2307: Cannot find module 'picomatch' or its corresponding type declarations.

This can be seen on https://github.com/xfix/live/actions/runs/3332827904/jobs/5514140592.

index.d.ts contains the following import.

import type { Matcher as Matcher_2 } from 'picomatch';

Matcher_2 is not used anywhere.

Reproduction

https://github.com/xfix/live/actions/runs/3332827904/jobs/5514140592

Steps to reproduce

No response

System Info

GitHub Actions, vite 3.2.0

Used Package Manager

npm

Logs

No response

Validations

@bluwy bluwy added the regression The issue only appears after a new release label Oct 27, 2022
@benmccann benmccann added bug p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) and removed pending triage labels Oct 27, 2022
@vizv
Copy link

vizv commented Oct 27, 2022

Having the same issue, have to install @types/picomatch to workaround this issue currently 😢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) regression The issue only appears after a new release
Projects
None yet
4 participants