ts lit based app fail after upgrading to 3.1.4

[christophe-g]

Describe the bug

Filing this in case other folks stumble on the same issue

Changes introduced in 3.1.4 make lit-based app (written in ts) fail with :

chunk-ZXEQAGIL.js?v=5aae4da4:439 Uncaught (in promise) Error: The following properties on element app-survey 
will not trigger updates as expected because they are set using class fields: disableProminent, prominent, showHelp, 
menu, matchedRoute. Native class fields and some compiled output will overwrite accessors used for detecting changes. 

See https://lit.dev/msg/class-field-shadowing for more information.

even though tsconfig has: "useDefineForClassFields": false

Workaround:

  esbuild: {
    target: 'es2021',
  },

in vite.config.js

Reproduction

https://stackblitz.com/edit/vitejs-vite-q1eiyr?file=index.html

Steps to reproduce

No response

System Info

NA

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[sapphi-red]

even though tsconfig has: "useDefineForClassFields": false

@christophe-g Do you have a reproduction of this one?
It works for me in that condition. https://stackblitz.com/edit/vitejs-vite-mppk5r?file=package.json,tsconfig.json

related: #10296

[christophe-g]

Thanks a lot @sapphi-red

It works for me in that condition

You are right, it does.

I really don't get what is happening on my locale install. Everything seems to work fine on stackblitz, but running on my machine fail (with same ts.config and vite.config.js, and with "useDefineForClassFields": false).

I'll enquire a bit more and close this issue if I am unable to identify what is coming in the way.

[sapphi-red]

Closing for now. Feel free to create a new issue if you success to create a reproduction.