From 732d60cc99c6ea4dfcf5fd625d36632a8dc6c078 Mon Sep 17 00:00:00 2001 From: Shinigami Date: Tue, 13 Jul 2021 17:05:08 +0200 Subject: [PATCH] chore: use eslint rule eqeqeq (#4234) --- .eslintrc.js | 1 + packages/create-vite/index.js | 2 +- packages/playground/testUtils.ts | 2 +- packages/vite/src/node/optimizer/scan.ts | 2 +- packages/vite/src/node/utils.ts | 2 +- 5 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 9f35fdb2f0d124..8e3e9b28cdceb1 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -14,6 +14,7 @@ module.exports = defineConfig({ ecmaVersion: 2020 }, rules: { + eqeqeq: ['warn', 'always', { null: 'never' }], 'no-debugger': ['error'], 'no-empty': ['warn', { allowEmptyCatch: true }], 'no-process-exit': 'off', diff --git a/packages/create-vite/index.js b/packages/create-vite/index.js index 5e2b0e75b0296f..a70f52812ef756 100755 --- a/packages/create-vite/index.js +++ b/packages/create-vite/index.js @@ -156,7 +156,7 @@ async function init() { }, { type: (_, { overwrite } = {}) => { - if (overwrite == false) { + if (overwrite === false) { throw new Error(red('✖') + ' Operation cancelled') } return null diff --git a/packages/playground/testUtils.ts b/packages/playground/testUtils.ts index 9c7235e000c48f..bb679ffe591435 100644 --- a/packages/playground/testUtils.ts +++ b/packages/playground/testUtils.ts @@ -24,7 +24,7 @@ Object.keys(colors).forEach((color) => { function componentToHex(c: number): string { const hex = c.toString(16) - return hex.length == 1 ? '0' + hex : hex + return hex.length === 1 ? '0' + hex : hex } function rgbToHex(rgb: string): string { diff --git a/packages/vite/src/node/optimizer/scan.ts b/packages/vite/src/node/optimizer/scan.ts index dc05371f3bfff2..c288dccc62abc7 100644 --- a/packages/vite/src/node/optimizer/scan.ts +++ b/packages/vite/src/node/optimizer/scan.ts @@ -229,7 +229,7 @@ function esbuildScanPlugin( // esbuild to keep crawling due to potential side effects. let m const original = js - while ((m = importsRE.exec(original)) !== null) { + while ((m = importsRE.exec(original)) != null) { // This is necessary to avoid infinite loops with zero-width matches if (m.index === importsRE.lastIndex) { importsRE.lastIndex++ diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts index 0aca0972b2b1b2..6ded895368fa7c 100644 --- a/packages/vite/src/node/utils.ts +++ b/packages/vite/src/node/utils.ts @@ -206,7 +206,7 @@ export function isObject(value: unknown): value is Record { } export function isDefined(value: T | undefined | null): value is T { - return value !== undefined && value !== null + return value != null } export function lookupFile(