From 23a51c6184587124bf20d270c27deb3fbb56d9a3 Mon Sep 17 00:00:00 2001 From: patak Date: Fri, 16 Sep 2022 16:06:47 +0200 Subject: [PATCH] fix: use isOptimizable to ensure version query (#10141) --- packages/vite/src/node/plugins/resolve.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/vite/src/node/plugins/resolve.ts b/packages/vite/src/node/plugins/resolve.ts index 97b032b2833e11..2f2ccb2fb9af96 100644 --- a/packages/vite/src/node/plugins/resolve.ts +++ b/packages/vite/src/node/plugins/resolve.ts @@ -29,6 +29,7 @@ import { isFileReadable, isNonDriveRelativeAbsolutePath, isObject, + isOptimizable, isPossibleTsOutput, isTsRequest, isWindows, @@ -181,7 +182,7 @@ export function resolvePlugin(resolveOptions: InternalResolveOptions): Plugin { if (isNodeModule && !resolved.match(DEP_VERSION_RE)) { const versionHash = depsOptimizer.metadata.browserHash - if (versionHash && OPTIMIZABLE_ENTRY_RE.test(resolved)) { + if (versionHash && isOptimizable(resolved, depsOptimizer.options)) { resolved = injectQuery(resolved, `v=${versionHash}`) } } @@ -750,7 +751,9 @@ export function tryNodeResolve( } // if we reach here, it's a valid dep import that hasn't been optimized. - const isJsType = OPTIMIZABLE_ENTRY_RE.test(resolved) + const isJsType = depsOptimizer + ? isOptimizable(resolved, depsOptimizer.options) + : OPTIMIZABLE_ENTRY_RE.test(resolved) let exclude = depsOptimizer?.options.exclude let include = depsOptimizer?.options.exclude