Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does the React plugin not support React 16? I couldn't find related documentation. #297

Open
7 tasks done
GRAMMAC1 opened this issue Mar 14, 2024 · 1 comment
Open
7 tasks done
Labels
documentation Improvements or additions to documentation

Comments

@GRAMMAC1
Copy link

Describe the bug

It seems that 1.0.0 already uses the JSX runtime. Does this mean that support for React 16 has been abandoned?

Reproduction

none

Steps to reproduce

No response

System Info

System:
    OS: macOS 12.6.3
    CPU: (10) x64 Apple M1 Pro
    Memory: 48.74 MB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.15.0 - ~/.nvm/versions/node/v18.15.0/bin/node
    Yarn: 1.22.19 - ~/.yarn/bin/yarn
    npm: 9.5.0 - ~/.nvm/versions/node/v18.15.0/bin/npm
    pnpm: 8.11.0 - ~/Library/pnpm/pnpm
  Browsers:
    Chrome: 122.0.6261.129
    Safari: 16.3
  npmPackages:
    @vitejs/plugin-react: ^4.2.1 => 4.2.1
    vite: ^5.1.4 => 5.1.6

Used Package Manager

yarn

Logs

No response

Validations

@ArnaudBarre ArnaudBarre added documentation Improvements or additions to documentation and removed pending triage labels Mar 29, 2024
@ArnaudBarre
Copy link
Member

Yeah I should document it. This plugin only make sense if your version of React support Fast Refresh, which means >= 16.9 IIRC.
JSX runtime was introduced in 17 IIRC, with this plugin you can get back to default JSX transform with jsxRuntime option.

I'll keep this one open and update the Readme next time I do a change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants