Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn if header contains <link> to manifest #666

Open
marwie opened this issue Feb 16, 2024 · 2 comments
Open

warn if header contains <link> to manifest #666

marwie opened this issue Feb 16, 2024 · 2 comments

Comments

@marwie
Copy link

marwie commented Feb 16, 2024

Hello

just ran into an issue where the manifest was still present in the header <link rel="manifest" href="./manifest.webmanifest">

Which resultet in the manifest being embedded and loaded via a data url where e.g. a relative start_url stopped working because it is resolved relative to the manifest file.

Capto_Capture 2024-02-17_02-58-23_AM

It would be great if VitePWA could emit a warning at the end if this is the case and the manifest is embedded but e.g. the start_url or icon urls are relative

Using PWA v0.18.2

@marwie marwie changed the title warn if header contains link to manifest warn if header contains <link> to manifest Feb 16, 2024
@userquin
Copy link
Member

userquin commented Feb 16, 2024

what do you mean? do you have the link in the index.html? if so just remove it

@marwie
Copy link
Author

marwie commented Feb 17, 2024

Sorry I dont have a live link anymore altough I can create a repro again if necessary. I just wanted to point out that it took me a while to realize that because of the index html header containing a <link rel="manifest" the Vite PWA manifest would be somehow embedded/encoded and therefore not work with relative icon and base_urls anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants