Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some revisions are null and not cached in the service worker #648

Open
vdegenne opened this issue Jan 22, 2024 · 1 comment
Open

Some revisions are null and not cached in the service worker #648

vdegenne opened this issue Jan 22, 2024 · 1 comment

Comments

@vdegenne
Copy link

Hello I don't know well about how Service Worker works, I'm using vite-plugin-pwa for simplicity, but I think something is not quite right here.

What caught my attention was this:
image

Some resources are retrieved from the memory cache and not from the Service Worker. So I checked sw.js generated by the plugin and here's what I found:

image

Some revision fields are null, those are files naturally generated from the builds, and I'm not doing anything fancy in my vite config :

https://github.com/vdegenne/symbols-font-composer/blob/77605f4b8c9cb5a0f7dabc412926a3c622282bfb/vite.config.js#L89-L118

(The whole project source is available where the file above is)

Is this a real issue? and if yes, what could be the reason?

@userquin
Copy link
Member

All assets generated by Vite will not have revision, every time you change something, the name will change, only static assets names will have a revision.

For context, check this issue: #163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants