feat: support rollup assets file names #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
benmccann
reviewed
Nov 13, 2022
| @@ -76,7 +76,7 @@ export async function resolveOptions(options: Partial<VitePWAOptions>, viteConfi | |||
| globDirectory: outDirRoot, | |||
| offlineGoogleAnalytics: false, | |||
| cleanupOutdatedCaches: true, | |||
| dontCacheBustURLsMatching: /\.[a-f0-9]{8}\./, | |||
| dontCacheBustURLsMatching: /[.-][a-f0-9]{8}\./, | |||
There was a problem hiding this comment.
I think the . here (and below) needs to be escaped?
There was a problem hiding this comment.
IIRC, in a character class (square brackets) any character except ^, -, ] or \ is a literal, and - requires escaping only if not the first nor last one.
There was a problem hiding this comment.
About the dot, IntelliJ showing a redundant escaping warning:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
dontCacheBustURLsMatchingis using Vite assets file names (<name>.<hash>.<ext>) and it will change to align it with Rollup default assets naming (<name>-<hash>.<ext>): vitejs/vite#10878.This PR just changes the regex to support both layouts.