feat: support mode when injectManifest #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yoyo930021
force-pushed
the
inject-mode-when-inject-manifest
branch
3 times, most recently
from
1709684
to
4b617f9
Compare
yoyo930021
force-pushed
the
inject-mode-when-inject-manifest
branch
from
4b617f9
to
9cc0dcc
Compare
yoyo930021
changed the title
userquin
approved these changes
Oct 13, 2022
antfu
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't support
modewhen injectManifest strategy.The workbox-build doesn't support it. ref: GoogleChrome/workbox#2588
But it can enable logs and some opt-in features.
This PR is refer to https://github.com/modernweb-dev/web/blob/master/packages/rollup-plugin-workbox/README.md#a-note-on-the-mode-config-property and https://github.com/chromeos/static-site-scaffold-modules/blob/main/modules/rollup-plugin-workbox-inject/README.md#rollupconfigjs