Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error In Documentation Example #1366

Closed
dustinws opened this issue Apr 13, 2018 · 1 comment
Closed

Error In Documentation Example #1366

dustinws opened this issue Apr 13, 2018 · 1 comment

Comments

@dustinws
Copy link

I noticed this error yesterday when looking through the documentation. The error is in the timeout example - notice how the err variable used in the .then block is never defined. Perhaps the .timeout property is on the response, or perhaps a .catch is required instead.

A link to the documentation

And a screenshot for quick reference.
screen shot 2018-04-13 at 9 09 22 am
@kornelski
Copy link
Contributor

Thanks

kornelski added a commit that referenced this issue Apr 13, 2018
@kornelski
Fix #1366 docs
75d1ca0
kornelski added a commit that referenced this issue Apr 15, 2018
@kornelski
Merge remote-tracking branch 'origin/master' into gh-pages
cc10687 
* origin/master:
  Lock marked version due to bug
  Fix #1366 docs
  Add flags for 201 & 422 responses
  Make GitHub happy
kornelski added a commit that referenced this issue May 15, 2018
@kornelski
Merge remote-tracking branch 'origin/master' into gh-pages
97a5632 
* origin/master:
  Fix #1366 docs
  Add flags for 201 & 422 responses
  Make GitHub happy
kornelski added a commit that referenced this issue May 15, 2018
@kornelski
Merge remote-tracking branch 'origin/master' into gh-pages
db898a6 
* origin/master: (26 commits)
  Explain timers kill uploads
  Access cookie in headers correctly
  Changelog
  Bump
  ES6ify
  ES6ify
  ES6ify
  Use Babel for browsers
  Don't allow req.abort().end()
  Reject promise on all errors
  Test file-not-found case
  Update dependencies
  ES6
  Test fix
  Longer timeout for sauselabs tests
  feat: Leave backticks unencoded in query strings where possible
  Bump Travis node version
  Bump
  Lock marked version due to bug
  Fix #1366 docs
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kornelski @dustinws