Vendor in ply as needed #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* vendored in some ply subcomponents - ply.lex - ply.yacc * updated rest of project to reflect ply vendoring * updated pyproject to configure black - retain defaults - skip linting on vendored ply module
|
This seems fine to me, thanks for the PR. setup.py compiles a parsetab via ply (see #56), it should be updated to use the internal version of ply now? |
|
Yah, that looks trivial now that it won't have be done conditionally. I'll cook a quick commit. |
|
This should now handle the parsetab generation by reverting #56 now that ply being importable isn't optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in issue #60 this handles vendoring in the current version of
ply.yaccandply.lexalong with updating the relevant build and test machinery to allow for testing and packaging.fixes #56
fixes #49
fixes #60
fixes #58