From 7dd25b46d8632819d1cb001e92737787a7f5fefb Mon Sep 17 00:00:00 2001 From: Bruce Weirdan Date: Fri, 23 Dec 2022 17:26:39 -0400 Subject: [PATCH] Fix missing version in PHARs build on GA We were overriding the root version with COMPOSER_ROOT_VERSION, so all PHARs had `dev-master` as the version for `vimeo/psalm` baked in. Fixed vimeo/psalm#7606 --- .github/workflows/build-phar.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-phar.yml b/.github/workflows/build-phar.yml index 26dd0be883c..2f06237b5ac 100644 --- a/.github/workflows/build-phar.yml +++ b/.github/workflows/build-phar.yml @@ -43,6 +43,8 @@ jobs: coverage: none - uses: actions/checkout@v3 + with: + fetch-depth: 0 # required for composer to automatically detect root package version - name: Get Composer Cache Directories id: composer-cache @@ -62,8 +64,9 @@ jobs: - name: Run composer install run: composer install -o - env: - COMPOSER_ROOT_VERSION: dev-master + # DO NOT set this, we need composer to figure out the version itself + # env: + # COMPOSER_ROOT_VERSION: dev-master - run: bin/build-phar.sh env: