Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ini_set types for arg value #8308

Merged
merged 1 commit into from Jul 22, 2022
Merged

Fixed ini_set types for arg value #8308

merged 1 commit into from Jul 22, 2022

Conversation

honca
Copy link
Contributor

@honca honca commented Jul 22, 2022

Hi guys,
in our codebase I have noticed that current version of Psalm has not updated ini_set types for the param $value.
Since the 8.1 it is allowed to accept this set of types: string|int|float|bool|null. Not only string.

https://www.php.net/manual/en/function.ini-set

Best,
Honca

@AndrolGenhald AndrolGenhald added bug easy problems Issues that can be fixed without background knowledge of Psalm internal stubs/callmap Help wanted good first issue release:fix The PR will be included in 'Fixes' section of the release notes and removed bug easy problems Issues that can be fixed without background knowledge of Psalm internal stubs/callmap Help wanted good first issue labels Jul 22, 2022
@AndrolGenhald AndrolGenhald merged commit 640d3b6 into vimeo:4.x Jul 22, 2022
@AndrolGenhald
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants