Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "Count" Report Format #8244

Merged
merged 1 commit into from Jul 11, 2022
Merged

New "Count" Report Format #8244

merged 1 commit into from Jul 11, 2022

Conversation

jack-worman
Copy link
Contributor

@jack-worman jack-worman commented Jul 10, 2022 •
edited

This is a format that displays the count of each issue type.
I requested this feature in #8225.

I look forward to being able to run: psalm --ignore-baseline --output-format=count

For example, the output of the above command on this code base is:

PossiblyUndefinedStringArrayOffset: 1
PossiblyUnusedProperty: 1
RedundantCondition: 1
ReferenceConstraintViolation: 1
UnusedClass: 1
UnusedPsalmSuppress: 1
InvalidPropertyAssignmentValue: 2
DocblockTypeContradiction: 3
PropertyNotSetInConstructor: 5
DeprecatedClass: 35
DeprecatedMethod: 44
DeprecatedProperty: 89
PossiblyUndefinedIntArrayOffset: 144

@AndrolGenhald AndrolGenhald added the release:feature The PR will be included in 'Features' section of the release notes label Jul 11, 2022
AndrolGenhald
AndrolGenhald reviewed Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@AndrolGenhald AndrolGenhald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing possibly worth discussing is the sorting, but sorting by issue count seems fine.

@orklah orklah merged commit 7f3d55d into vimeo:4.x Jul 11, 2022
@orklah
Copy link
Collaborator

orklah commented Jul 11, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrolGenhald AndrolGenhald AndrolGenhald left review comments

Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jack-worman @orklah @AndrolGenhald