Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ltrim may return class-string #8218 #8219

Merged
merged 1 commit into from Jul 6, 2022
Merged

fix: ltrim may return class-string #8218 #8219

merged 1 commit into from Jul 6, 2022

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Jul 6, 2022

Fixes #8218

@Tofandel Tofandel mentioned this pull request Jul 6, 2022
Merged
@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jul 6, 2022
@orklah
Copy link
Collaborator

orklah commented Jul 6, 2022

Thanks! I'm not a big fan of string manipulation functions returning class-strings, but I guess I see why you need it

@orklah orklah merged commit 6e27c23 into vimeo:4.x Jul 6, 2022
@staabm staabm mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ltrim(class-string, '\\') should return a class-string
2 participants
@Tofandel @orklah