Fix several CallMap function signatures #8217
Conversation
othercorey
force-pushed
the
fix-callmap-funcs
branch
2 times, most recently
from
d7afd82
to
4b77691
Compare
dictionaries/CallMap_historical.php
Outdated
| @@ -10001,7 +10001,7 @@ | |||
| 'copy' => ['bool', 'from'=>'string', 'to'=>'string', 'context='=>'resource'], | |||
| 'cos' => ['float', 'num'=>'float'], | |||
| 'cosh' => ['float', 'num'=>'float'], | |||
| 'count' => ['int', 'value'=>'Countable|array|SimpleXMLElement|ResourceBundle', 'mode='=>'int'], | |||
| 'count' => ['int', 'value'=>'mixed', 'mode='=>'int'], | |||
There was a problem hiding this comment.
I think this was intentionally more specific.
There was a problem hiding this comment.
SimpleXMLElement and ResourceBundle implement Countable so they aren't necessary. Should we just make it Countable|array for all versions?
There was a problem hiding this comment.
Not for historical versions: https://3v4l.org/N8LQ5
There was a problem hiding this comment.
Though I'm fine removing SimpleXMLElement from the signature starting from 7.4. Less complexity is always good. Not sure about ResourceBundle though
There was a problem hiding this comment.
I was going to check whether it always implemented that interface too. I'll adjust it back up based on that.
Some of these are tricky to follow the implementation.
There was a problem hiding this comment.
According to the changelog ResourceBundle started implementing Countable in 7.4.
There was a problem hiding this comment.
Restored the historical signature and moved the change to 8.0 where the TypeError was thrown.
othercorey
force-pushed
the
fix-callmap-funcs
branch
from
4b77691
to
e0ebfe1
Compare
orklah
added
the
release:fix
|
Thanks! |
partially reverts vimeo#8217
partially reverts vimeo#8217
partially reverts vimeo#8217
partially reverts vimeo#8217
partially reverts vimeo#8217
partially reverts vimeo#8217
Fixed several standard functions.