Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve @return annotation for implode() so that it can handle non-empty-array of non-empty-strings case #7967

Merged
merged 3 commits into from May 17, 2022
Merged

Improve @return annotation for implode() so that it can handle non-empty-array of non-empty-strings case #7967

merged 3 commits into from May 17, 2022

Conversation

hirokinoue
Copy link
Contributor

Fixes: #7607

@AndrolGenhald
Copy link
Collaborator

Could you mention that this is for implode in the title? PR titles go in the changelog and the current title is a bit unclear.

@AndrolGenhald AndrolGenhald added the release:feature The PR will be included in 'Features' section of the release notes label May 14, 2022
@hirokinoue hirokinoue changed the title Improve @return annotation so that it can handle non-empty-array of non-empty-strings case Improve @return annotation for implode() so that it can handle non-empty-array of non-empty-strings case May 15, 2022
@hirokinoue
Copy link
Contributor Author

Thanks! I fixed the title.

@orklah orklah merged commit 894e4e4 into vimeo:4.x May 17, 2022
@orklah
Copy link
Collaborator

orklah commented May 17, 2022

Thanks!

@hirokinoue hirokinoue deleted the fix_return_type branch September 1, 2022 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implode of non-empty-list should always inferred as non-empty-string
3 participants
@hirokinoue @AndrolGenhald @orklah