Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parse_url() return type #7293

Merged
merged 3 commits into from Jan 4, 2022
Merged

Fix parse_url() return type #7293

merged 3 commits into from Jan 4, 2022

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Jan 4, 2022

Fixes #7078

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 4, 2022
@orklah orklah merged commit e41fc67 into vimeo:4.x Jan 4, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 4, 2022

Thanks!

@villfa villfa deleted the fix/7078 branch January 4, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah orklah left review comments

Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parse_url() may return false for any combination of inputs
2 participants
@villfa @orklah