Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template and variable types inference for methods marked with psalm-if-this-is #7259

Merged
merged 4 commits into from Jan 2, 2022
Merged

Template and variable types inference for methods marked with psalm-if-this-is #7259

merged 4 commits into from Jan 2, 2022

Conversation

klimick
Copy link
Contributor

@klimick klimick commented Dec 31, 2021

Closes #7258

@klimick
Copy link
Contributor Author

klimick commented Jan 1, 2022

Don't know what to do with Psalm errors and where they came from)

@orklah
Copy link
Collaborator

orklah commented Jan 1, 2022 •
edited

Test still pass on master after a re-run: https://github.com/vimeo/psalm/actions/runs/1642095334

It must be caused by something in your PR

EDIT: this line seems to be the only one not in an if(if_this_is): https://github.com/vimeo/psalm/pull/7259/files#diff-1904530672f018967d2fc1e7bd1941bd12389fda0ea3d001883002e2554dbcb8R216

@orklah
Copy link
Collaborator

orklah commented Jan 1, 2022

Give me a sign if you're stuck, I'll try to clone your PR and check it out

@klimick
Copy link
Contributor Author

klimick commented Jan 1, 2022

Solved. In some situations MethodStorage was null.

@weirdan weirdan added the release:feature The PR will be included in 'Features' section of the release notes label Jan 2, 2022
@weirdan weirdan merged commit 376d2a3 into vimeo:master Jan 2, 2022
@weirdan
Copy link
Collaborator

weirdan commented Jan 2, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

psalm-if-this-is enhancements
3 participants
@klimick @orklah @weirdan