Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from deprecated Composer 1 to Composer 2 runtime api #7239

Merged
merged 4 commits into from Jan 2, 2022
Merged

Move from deprecated Composer 1 to Composer 2 runtime api #7239

merged 4 commits into from Jan 2, 2022

Conversation

DeyV
Copy link

@DeyV DeyV commented Dec 29, 2021

No description provided.

@orklah
Copy link
Collaborator

orklah commented Dec 29, 2021

phar build is failing in CI.

It must have something to do with scoper.inc.php file, but I was unable to see why PackageVersion worked but not the new package. Can you try to tweak with that to see if you can fix it?

@DeyV
Copy link
Author

DeyV commented Dec 31, 2021

I fixed this problem.

To full remove dependency of composer/package-versions-deprecated
release of psalm/psalm-plugin-phpunit#116 is needed

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 2, 2022
@orklah orklah changed the base branch from master to 4.x January 2, 2022 17:35
@orklah orklah merged commit 33628ca into vimeo:4.x Jan 2, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 2, 2022

Thanks!

@weirdan
Copy link
Collaborator

weirdan commented Jan 3, 2022

I think this broke psalm.dev:

Psalm runner output: 

Internal Psalm error on line 22 - /src/OnlineChecker.php: Class "PackageVersions\Versions" not found

@weirdan
Copy link
Collaborator

weirdan commented Jan 3, 2022

Fixed in psalm/psalm.dev@8c65f63

@orklah orklah mentioned this pull request Jan 7, 2022
Closed
weirdan added a commit to weirdan/psalm that referenced this pull request Jan 8, 2022
@weirdan
Revert "Merge pull request vimeo#7239 from DeyV/master"
a4878ac 
This reverts commit 33628ca, reversing
changes made to 216cf6c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah orklah left review comments

Assignees
No one assigned
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DeyV @orklah @weirdan