Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix optional arguments in number_format (fixes #7158). #7159

Merged

Conversation

AndrolGenhald
Copy link
Collaborator

Before PHP 8.0 number_format didn't accept 3 arguments. Now that this has been fixed only one entry in the callmap is needed.

@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 14, 2021
@orklah orklah linked an issue Dec 14, 2021 that may be closed by this pull request
@orklah orklah merged commit 41fe553 into vimeo:master Dec 14, 2021
@orklah
Copy link
Collaborator

orklah commented Dec 14, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive errors with number_format function
3 participants