Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldap_set_rebind_proc signature #7145

Merged
merged 2 commits into from Dec 14, 2021
Merged

Fix ldap_set_rebind_proc signature #7145

merged 2 commits into from Dec 14, 2021

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Dec 13, 2021

Hi,

This PR fixes a false positive about ldap_set_rebind_proc():

Argument 2 of ldap_set_rebind_proc expects string, callable provided

See:

@weirdan
Copy link
Collaborator

weirdan commented Dec 13, 2021

@villfa you need to update Callmap_historical as well (it contains signatures as they were in 7.0).

@villfa
Copy link
Contributor Author

villfa commented Dec 13, 2021

Thanks, it's done.

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Dec 13, 2021
@orklah
Copy link
Collaborator

orklah commented Dec 14, 2021

Thanks!

@orklah orklah merged commit 2cd7b19 into vimeo:master Dec 14, 2021
@villfa villfa deleted the fix/ldap_set_rebind_proc branch December 15, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants