Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid positional arg after named arg #7136

Merged
merged 3 commits into from Dec 12, 2021
Merged

Forbid positional arg after named arg #7136

merged 3 commits into from Dec 12, 2021

Conversation

klimick
Copy link
Contributor

@klimick klimick commented Dec 11, 2021

Closes #7104

orklah
orklah reviewed Dec 11, 2021
View reviewed changes
tests/ArgTest.php Outdated Show resolved Hide resolved
@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Dec 11, 2021
@orklah
Copy link
Collaborator

orklah commented Dec 11, 2021

Thanks! That's great!

@orklah
Copy link
Collaborator

orklah commented Dec 11, 2021

Whoops, Almost merged, but you have still a CS issue. Can you fix that first?

@weirdan weirdan merged commit 41ca7f7 into vimeo:master Dec 12, 2021
@weirdan
Copy link
Collaborator

weirdan commented Dec 12, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orklah orklah orklah left review comments

Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid use positional argument after named argument
3 participants
@klimick @orklah @weirdan