remove the remaining dynamic property assignment #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orklah
added
the
release:fix
TysonAndre
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
That's what I had in mind.
I don't expect issues: Looking at this again, class PhpParser\Node\Stmt\Class_ extends Declaration and its subclasses are a distinct group of classes from PhpParser\Node\Name, so this won't conflict with the existing attribute of the same name used with PhpParser\Node\Name in SimpleNameResolver::resolveName.
I was confused by
setAttribute('namespacedNameObject'), why Object?
At the time I hadn't looked into whether any use cases for the attribute of the same name would conflict, but it turns out they won't conflict
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to fix #7007
But reading the issue again, I'm not sure I got it right the first time.
@TysonAndre , can you confirm this is what you had in mind? I was confused by
setAttribute('namespacedNameObject'), why Object?(On an unrelated note, the reason why I didn't find those two for #6656 is because there is a @Property on PHP-Parser which messed with my detection)