Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysqli_fetch_* stubs #7014

Merged
merged 5 commits into from Nov 29, 2021
Merged

Conversation

kamil-tekiela
Copy link
Contributor

I have just noticed during testing that I have specified the wrong type in the previous PR. While correcting it, I also decided to provide more specific types. I am not sure if the types for mysqli_fetch_array() works this way, but I hope it does.

@orklah
Copy link
Collaborator

orklah commented Nov 28, 2021

Can you use the occasion to fix the indentation in mysqli stub? :)

@kamil-tekiela kamil-tekiela marked this pull request as draft November 28, 2021 11:32
@kamil-tekiela
Copy link
Contributor Author

I fixed the indentation and I have also decided to properly specify the type. The type is taken from fetch_column() - false. In the case of MYSQLI_NUM it will be a list. In the case of fetch_all() it is always a list of one of the three options.

I have also noticed I forgot to fix fetch_fields()

@kamil-tekiela kamil-tekiela marked this pull request as ready for review November 28, 2021 13:43
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 28, 2021
dictionaries/CallMap.php Outdated Show resolved Hide resolved
@weirdan weirdan marked this pull request as draft November 28, 2021 22:35
@kamil-tekiela kamil-tekiela marked this pull request as ready for review November 28, 2021 22:44
@weirdan weirdan merged commit f1d47cc into vimeo:master Nov 29, 2021
@weirdan
Copy link
Collaborator

weirdan commented Nov 29, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants