Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using length instead of count for php 7.1 compatibility #6981

Merged
merged 1 commit into from Nov 23, 2021

Conversation

AlessandroMinoccheri
Copy link
Contributor

@AlessandroMinoccheri AlessandroMinoccheri commented Nov 23, 2021

using lenght istead of count for php 7.1 compatibility

Fixes #6980

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 23, 2021
@orklah orklah merged commit 60f0fd1 into vimeo:master Nov 23, 2021
@orklah
Copy link
Collaborator

orklah commented Nov 23, 2021

Thanks for the on point analysis and quick fix :)

@AlessandroMinoccheri AlessandroMinoccheri changed the title using lenght istead of count for php 7.1 compatibility using length instead of count for php 7.1 compatibility Nov 23, 2021
@AlessandroMinoccheri
Copy link
Contributor Author

Thanks to you @orklah!

weirdan pushed a commit that referenced this pull request Nov 23, 2021
using lenght istead of count for php 7.1 compatibility
@weirdan
Copy link
Collaborator

weirdan commented Nov 23, 2021

@AlessandroMinoccheri your fix is now available in 4.13.1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with version 4.13.0 using DOMNodeList::count introduced only from PHP 7.2
3 participants