fix counting array properties when some are Never #6971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #6969
There are still weird behaviours in here, for example in https://psalm.dev/r/522d483a64, removing the standalone
if(rand(0,1))
condition mask the issue, so I guess Psalm perform some simplifications in arrays shapes when closing a condition or something like that.However, this change is not dirty nor harmful and will improve the situation, so it should not be an issue