check __callStatic purity instead of the pseudoMethod purity

[orklah]

In #3180, users reported that pseudo methods with @method static plus a return type were pure by default.

It was not accurate, it's just that impurity was not checked. In #6724, I added code to check purity through __callStatic by checking the pure attribute of the pseudo method that was called.

It was successful in flagging impure calls in pure context but I did not see that the pure calls in pure context were now broken because I used the pure flag of the pseudo method (that is never flagged) instead of the pure flag of __callStatic itself.

This is now fixed and both way works, so this will fix #6941

[weirdan]

I wonder whether it would work with usePhpDocMethodsWithoutMagicCall="true".

[orklah]

I wonder whether it would work with usePhpDocMethodsWithoutMagicCall="true".

Both tests I added use __callStatic so the property does nothing here (I tested that locally)

However, if you have this config and you try to call a static method declared in docblock, you have no way to declare the call as pure but Psalm won't complain about it.

It could be an enhancement

[Ocramius]

Thanks @orklah!