Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid SoapClient::__doRequest() response type #6927

Merged
merged 1 commit into from Nov 22, 2021
Merged

Invalid SoapClient::__doRequest() response type #6927

merged 1 commit into from Nov 22, 2021

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Nov 15, 2021

Fixes #6901

The return type of SoapClient::__doRequest() is actually ?string instead of string.
See

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 22, 2021
@orklah
Copy link
Collaborator

orklah commented Nov 22, 2021

Thanks! Sorry for the delay, I forgot about this PR...

@orklah orklah merged commit e13c48a into vimeo:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid SoapClient::__doRequest() signature
2 participants
@veewee @orklah