Psalter wants to add "@result never" in void methods

[UlrichBoehm]

Running the following code with psalter (dry-run, all issues) leads to the suggestion to add a doc block with "(at)return never" which is wrong.

function checkForFoo(string $test): void
{
    if (str_contains($test, 'foo')) {
        throw new \Exception('No Foo here!');
    }
}

FYI @kkmuffme

[psalm-github-bot]

Hey @UlrichBoehm, can you reproduce the issue on https://psalm.dev ?

[UlrichBoehm]

It's reproducible as soon as you enable the setting "Force return types to be as tight as possible".
https://psalm.dev/r/40196637cc

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/40196637cc

<?php

function checkForFoo(string $test): void
{
    if (str_contains($test, 'foo')) {
        throw new \Exception('No Foo here!');
    }
}

Psalm output (using commit ef02ded):

INFO: LessSpecificReturnType - 3:37 - The inferred return type 'never' for checkForFoo is more specific than the declared return type 'void'

[kkmuffme]

Duplicate of #8862
This is not a bug with the "never" check, but a bug in general, e.g.
https://psalm.dev/r/b0e397c14e
https://psalm.dev/r/6ffb302b9e

Please create a PR to fix the implicit returns

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b0e397c14e

<?php

function foo(): void
{
    if (random_int(0, 1) === 1) {
        return false;
    }
}

Psalm output (using commit ef02ded):

ERROR: InvalidReturnStatement - 6:16 - No return values are expected for foo

INFO: LessSpecificReturnType - 3:17 - The inferred return type 'false' for foo is more specific than the declared return type 'void'

ERROR: InvalidFalsableReturnType - 3:17 - The declared return type 'void' for foo does not allow false, but 'false' contains false

https://psalm.dev/r/6ffb302b9e

<?php

function foo(): void
{
    if (random_int(0, 1) === 1) {
        return 10;
    }
}

Psalm output (using commit ef02ded):

ERROR: InvalidReturnStatement - 6:16 - No return values are expected for foo

ERROR: InvalidReturnType - 3:17 - The declared return type 'void' for foo is incorrect, got '10'