Fix assert testing callmap return types #8676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
commented
Nov 6, 2022
| @@ -282,6 +282,7 @@ class InternalCallMapHandlerTest extends TestCase | |||
| 'sqlsrv_prepare', | |||
| 'sqlsrv_query', | |||
| 'sqlsrv_server_info', | |||
| 'ssh2_forward_accept', | |||
There was a problem hiding this comment.
The extension defined 2 optional parameters (host and port) that are unused in the code and undocumented in PHP docs but are reflected.
othercorey
commented
Nov 6, 2022
| if ($expectedType !== null) { | ||
| $this->assertTypeValidity($expectedType, $entryReturnType, true, 'CallMap entry has incorrect return type'); | ||
| } else { | ||
| $this->assertNotEmpty($entryReturnType); |
There was a problem hiding this comment.
I'm not sure if this is ever true or if the parse checks above catch this, but we should define a return type at least.
weirdan
added
the
release:internal
|
Thanks! That looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8675
This removes the assert that callmap return type is empty if PHP does not provide a return type.
Fixes a couple other errors I encountered when running callmap tests.