Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serialize is not pure for array of object #8652

Merged
merged 5 commits into from Nov 3, 2022
Merged

serialize is not pure for array of object #8652

merged 5 commits into from Nov 3, 2022

Conversation

VincentLanglet
Copy link
Contributor

No description provided.

@VincentLanglet VincentLanglet marked this pull request as ready for review November 3, 2022 12:34
@VincentLanglet VincentLanglet mentioned this pull request Nov 3, 2022
Merged
@orklah
Copy link
Collaborator

orklah commented Nov 3, 2022

Seems good to me. Can you fix the CS errors?

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Nov 3, 2022
@orklah
Copy link
Collaborator

orklah commented Nov 3, 2022

Thanks!

@orklah orklah merged commit 3daad0c into vimeo:4.x Nov 3, 2022
@VincentLanglet VincentLanglet deleted the improveSerializeSupport branch November 3, 2022 19:31
This was referenced Dec 12, 2022
Merged
Open
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
This was referenced Dec 12, 2022
Merged
Open
Merged
Open
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VincentLanglet @orklah