Fix Spl file handling signatures #8644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After a little digging all these methods just wrap php_stat and the standard file methods which return false on failutre so this updates the signature to reflect that. |
neclimdul
force-pushed
the
SplFile-getSize
branch
from
e572928
to
e8fb060
Compare
|
Thanks! Seems like SplTempFileObject inherits SplFileObject so those changes should apply to it too. Could you make those changes? |
|
@orklah think I got SplFileInfo, SplFileObject, and SplTempFileObject so should have covered everything. |
Update SplFileInfo method signatures and related classes. Fixes vimeo#8642
orklah
force-pushed
the
SplFile-getSize
branch
from
e8fb060
to
a1f40c9
Compare
orklah
added
the
release:fix
|
Oh right, I was confused because CI didn't run properly. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SplFileInfo method signatures and related classes.
Fixes #8642